home: Show starred-message count in main menu, subject to user setting #1999

chrisbobbe · 2025-11-20T00:58:01Z

Stacked atop #1998.

"Subject to user setting" refers to the "toggle starred messages counter" setting: https://zulip.com/help/star-a-message#toggle-starred-messages-counter

Fixes-partly: #1088

Before this (but after #1998)	After

chrisbobbe · 2025-11-20T01:00:06Z

cc @alya

alya · 2025-11-20T04:57:41Z

The screenshots look good to me! We should remember to note that the setting affects the mobile app in https://zulip.com/help/star-a-message#toggle-starred-messages-counter.

…ounts

Fixes-partly: zulip#1088

The buttons were 48px instead of 44px tall, and the label's line height was 26px instead of 23px.

Fixes-partly: zulip#1088

rajveermalviya

Thanks @chrisbobbe! LGTM and test great, moving over to Greg's review.

gnprice

Thanks! Here's comments on the first 7/8 commits, including the new data structure:
a3d7fd8 unreads [nfc]: Factor out countInAllDms, for public use and as a helper
45bfcb0 unreads: Exclude muted DM conversations in combined-feed and all-dm counts
248cab2 home: Show unread counts in main menu
e8f51b2 home: Tweak main-menu buttons to follow Figma
247a3d4 api: Add UserSettings.starredMessageCounts
a22b49f api: Add starredMessages to initial snapshot
34f9a0b message: Add MessageStore.starredMessages

and a brief look at the last commit with the UI changes:
1e74454 home: Show starred-message count in main menu, subject to user setting

gnprice · 2025-11-25T01:16:41Z

lib/model/message.dart

    };
-
    if (isAdd && (event as UpdateMessageFlagsAddEvent).all) {


nit: these stanzas don't become any more closely related with this change; in fact they become more separate, because this adds another stanza below which consumes isAdd separately

gnprice · 2025-11-25T01:22:59Z

lib/model/message.dart

+  /// All starred messages, as message IDs.
+  Set<int> get starredMessages;


Hmm, I see.

I'm trying to think if there are other cases where this should get updated. I guess maybe not:

We can learn of messages through handleMessageEvent. But maybe those can't ever be starred.

We can learn of messages through reconcileMessages. But maybe if those are starred then they should already be in this set.

I think it'd be good to make that reasoning explicit, though, in those methods. Probably including asserts to verify those expectations.

gnprice · 2025-11-25T01:25:32Z

lib/model/store.dart

+        if (_messages.handleDeleteMessageEvent(event)) {
+          notifyListeners();
+        }
        unreads.handleDeleteMessageEvent(event);


It makes me a bit nervous to be calling notifyListeners at a point where the event has been only partially applied — the store is in a somewhat inconsistent state.

Instead let's delay the notifyListeners call to the end.

gnprice · 2025-11-25T01:34:01Z

test/model/message_test.dart

+      await prepareMessages([message]);
+      check(store).starredMessages.single.equals(message.id);
+      await store.handleEvent(eg.deleteMessageEvent([message]));
+      checkNotifiedOnce();


This line is a bit confusing — it checks that the list view-model notified its listeners, but not whether the store did.

I think the key case here would actually be with prepareMessages not knowing about the message. That exercises the situation where the app hasn't gone and fetched a message list that had the starred message, and only knows about it through the list in the initial snapshot.

gnprice · 2025-11-25T01:36:51Z

test/model/message_test.dart

+        void checkPerAccountStoreNotified({required int count}) {
+          check(perAccountStoreNotifiedCount).equals(count);
+          notifiedCount = 0;


Suggested change

void checkPerAccountStoreNotified({required int count}) {

check(perAccountStoreNotifiedCount).equals(count);

notifiedCount = 0;

void checkPerAccountStoreNotified({required int count}) {

check(perAccountStoreNotifiedCount).equals(count);

perAccountStoreNotifiedCount = 0;

right?

gnprice · 2025-11-25T01:38:51Z

test/model/message_test.dart

+        await prepareMessages([message1, message2]);
+        check(store).starredMessages.isEmpty();
+        await store.handleEvent(
+          mkAddEvent(MessageFlag.starred, [message1.id, message2.id]));


Suggested change

await prepareMessages([message1, message2]);

check(store).starredMessages.isEmpty();

await store.handleEvent(

mkAddEvent(MessageFlag.starred, [message1.id, message2.id]));

await prepareMessages([message2]);

check(store).starredMessages.isEmpty();

await store.handleEvent(

mkAddEvent(MessageFlag.starred, [message1.id, message2.id]));

That way we check that it works both with messages that the message store knows about, and those that it doesn't.

(Similarly for removing the flag, below.)

gnprice · 2025-11-25T01:40:54Z

lib/widgets/unread_count_badge.dart

-class UnreadCountBadge extends StatelessWidget {
-  const UnreadCountBadge({
+/// See [CounterStyle] and [CounterKind] for the possible variants.
+class Counter extends StatelessWidget {


Maybe CounterBadge?

The name "counter" feels awfully generic — it doesn't sound like necessarily even a widget, more like some kind of data structure that keeps count of things.

chrisbobbe requested a review from rajveermalviya November 20, 2025 00:58

chrisbobbe assigned rajveermalviya Nov 20, 2025

chrisbobbe added the maintainer review PR ready for review by Zulip maintainers label Nov 20, 2025

chrisbobbe added the product review Added by maintainers when a PR needs product review label Nov 20, 2025

chrisbobbe added 8 commits November 20, 2025 14:17

unreads [nfc]: Factor out countInAllDms, for public use and as a helper

a3d7fd8

unreads: Exclude muted DM conversations in combined-feed and all-dm c…

45bfcb0

…ounts

home: Show unread counts in main menu

248cab2

Fixes-partly: zulip#1088

home: Tweak main-menu buttons to follow Figma

e8f51b2

The buttons were 48px instead of 44px tall, and the label's line height was 26px instead of 23px.

api: Add UserSettings.starredMessageCounts

247a3d4

api: Add starredMessages to initial snapshot

a22b49f

message: Add MessageStore.starredMessages

34f9a0b

home: Show starred-message count in main menu, subject to user setting

1e74454

Fixes-partly: zulip#1088

chrisbobbe force-pushed the pr-starred-message-count-main-menu branch from 5d32321 to 1e74454 Compare November 20, 2025 22:17

rajveermalviya approved these changes Nov 21, 2025

View reviewed changes

rajveermalviya added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Nov 21, 2025

rajveermalviya assigned gnprice and unassigned rajveermalviya Nov 21, 2025

rajveermalviya requested a review from gnprice November 21, 2025 15:57

gnprice reviewed Nov 25, 2025

View reviewed changes

		/// All starred messages, as message IDs.
		Set<int> get starredMessages;

home: Show starred-message count in main menu, subject to user setting #1999

Are you sure you want to change the base?

home: Show starred-message count in main menu, subject to user setting #1999

Uh oh!

Conversation

chrisbobbe commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisbobbe commented Nov 20, 2025

Uh oh!

alya commented Nov 20, 2025

Uh oh!

rajveermalviya left a comment

Choose a reason for hiding this comment

Uh oh!

gnprice left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chrisbobbe commented Nov 20, 2025 •

edited

Loading