content: Render large emoji in emoji-only paragraphs #2018
+56
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi, welcome! This PR will need test coverage for the feature before we can review it. |
Author
|
Thanks! I'll work on adding the test coverage and will push an update shortly. |
sarafarajnasardi
force-pushed
the
emoji-only-messages-at-larger-size
branch
from
f39d122 to
4f19586
Compare
Author
|
I have added the tests coverage |
When a message consists of a single paragraph containing only emojis (Unicode or custom image emojis) and whitespace, render them at a larger size. This brings the mobile app's presentation into parity with the web app. To support this, `MessageImageEmoji` is updated to derive its size from the ambient text style rather than a fixed 20px value. This ensures custom emojis scale proportionally with the increased font size. Fixes: zulip#1995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content: Render large emoji in emoji-only paragraphs
Summary
This PR updates the message rendering to display paragraphs containing only emojis (Unicode or custom image emojis) at a larger size. This brings the mobile app's presentation into parity with the web app.
To support this,
MessageImageEmojihas been updated to derive its size from the ambient text style rather than a fixed pixel value, ensuring custom emojis scale proportionally with the font size.Screenshots
Changes
DefaultTextStylefor these paragraphs.MessageImageEmojito respect the ambientfontSize, enabling it to grow when the parent paragraph's font size increases.References
Fixed Issues
Fixes: #1995