content: Fix **bold code** rendering with regular weight
#501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
If #439 is merged first, I should update the commit message for content: Fix because at that point the needed |
This comment was marked as resolved.
This comment was marked as resolved.
chrisbobbe
force-pushed
the
pr-small-bold-content-fixes
branch
from
30cbd05 to
26fa0f8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
gnprice
reviewed
Feb 2, 2024
Member
gnprice
left a comment
gnprice
left a comment
There was a problem hiding this comment.
Thanks! One small comment below; otherwise LGTM.
|
|
||
| InlineSpan build() { | ||
| InlineSpan build(BuildContext context) { | ||
| _context = context; |
Member
There was a problem hiding this comment.
Suggested change
| _context = context; | |
| assert(_context == null); | |
| _context = context; |
Member
|
(Plus this, I guess:)
|
Our experience with variable-weight fonts is that, whenever we use
such a font, we need to specify a "wght" value, even if we want the
text to appear in the boring, regular weight. If we don't specify a
"wght", the text will appear in an extremely light weight.
We use a variable-weight font (Source Code Pro) for rendering inline
code spans, so that's why we were using weightVariableTextStyle
here. As an unfortunate result, when a code span appears inside a
bold ("strong") span, the outer span's bold-weight style has been
getting clobbered, and the code span appears in regular weight.
Fortunately, removing the `weightVariableTextStyle` from the inline
code style doesn't actually cause any inline spans to appear at
minimum weight. This is a relief, and it follows from the presence
of a `weightVariableTextStyle` applied widely across the app; see
zulipTypography and 6784ef9. We apply it widely across the app
because we apply Source Sans 3 widely across the app, and that is
also a variable-weight font. Moreover, Source Code Pro and Source
Sans 3 seem closely related (and were designed by the same person),
so it's likely that their "wght" axes are identical.
Fixes: zulip#498
chrisbobbe
force-pushed
the
pr-small-bold-content-fixes
branch
from
26fa0f8 to
4c0c6cd
Compare
Collaborator
Author
|
Thanks for the review! Revision pushed. |
Member
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also format
**bold text**using weightVariableTextStyle, fixing #499, and update a comment to point to #500.Fixes: #498
Fixes: #499