Skip to content

Conversation

@robertsLando
Copy link
Member

Fixes #4427

@robertsLando robertsLando mentioned this pull request Oct 20, 2025
3 tasks
@coveralls
Copy link

coveralls commented Oct 20, 2025

Pull Request Test Coverage Report for Build 18715703503

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 20.278%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/app.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 18649018373: -0.002%
Covered Lines: 4033
Relevant Lines: 21090

💛 - Coveralls

@kvaster
Copy link
Contributor

kvaster commented Oct 20, 2025

For me it doesn't help:

2025-10-20 13:39:47.245 ERROR APP: Error while loading ./../../plugins/zwavejs-prom plugin Directory import '/home/zwave/plugins/zwavejs-prom' is not supported resolving ES modules imported from /home/zwave/zwavejsui/server/app.js
Error: Directory import '/home/zwave/plugins/zwavejs-prom' is not supported resolving ES modules imported from /home/zwave/zwavejsui/server/app.js
    at finalizeResolution (node:internal/modules/esm/resolve:262:11)
    at moduleResolve (node:internal/modules/esm/resolve:864:10)
    at defaultResolve (node:internal/modules/esm/resolve:990:11)
    at ModuleLoader.#cachedDefaultResolve (node:internal/modules/esm/loader:755:20)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:732:38)
    at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:317:38)
    at onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:683:36)
    at TracingChannel.tracePromise (node:diagnostics_channel:350:14)
    at ModuleLoader.import (node:internal/modules/esm/loader:682:21)
    at defaultImportModuleDynamicallyForModule (node:internal/modules/esm/utils:229:31)

@robertsLando
Copy link
Member Author

@kvaster tried with nodejs 22?

@kvaster
Copy link
Contributor

kvaster commented Oct 20, 2025

@robertsLando , I think it was nodejs 24 already...

@robertsLando
Copy link
Member Author

Yeah >= 22 is ok, if that doesn't work I will give a try to check if converting your to an esm module works

@robertsLando
Copy link
Member Author

@kvaster @gdombiak you have to convert plugins to es modules:

export default class MyPlugin {
	constructor(ctx) {
	}
}

@robertsLando robertsLando merged commit 9ad1318 into master Oct 22, 2025
7 of 11 checks passed
@robertsLando robertsLando deleted the plugins-fix branch October 22, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugins no longer load

4 participants