Add onRune parameter, utf8 package in plugins.md#3100
Merged
JoeKar merged 1 commit intomicro-editor:masterfrom Mar 12, 2024
Merged
Add onRune parameter, utf8 package in plugins.md#3100JoeKar merged 1 commit intomicro-editor:masterfrom
JoeKar merged 1 commit intomicro-editor:masterfrom
Conversation
Add bufpane in parameters of onRune, preRune, and unicode/utf8 Go package in plugins.md.
Andriamanitra
approved these changes
Jan 13, 2024
Contributor
Andriamanitra
left a comment
Andriamanitra
left a comment
There was a problem hiding this comment.
👍
"humanize" seems to be also missing from the list: https://github.com/zyedidia/micro/blob/c2cebaa3d19fbdd924d411ee393c03e3e7804435/internal/lua/lua.go#L75-L78
Contributor
Author
|
There are only packages that are in the Go standard library in the list where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bufpane where a rune is entered is passed when
onRune,preRuneare called andunicode/utf8can be used in plugins, but the parameter and package were not written inplugins.mdso they have been added in the file in this pull request.