Forward resize event to both TabList and InfoBar#3179
Merged
JoeKar merged 1 commit intomicro-editor:masterfrom Mar 21, 2024
Merged
Forward resize event to both TabList and InfoBar#3179JoeKar merged 1 commit intomicro-editor:masterfrom
JoeKar merged 1 commit intomicro-editor:masterfrom
Conversation
dmaluka
commented
Mar 16, 2024
dmaluka
force-pushed
the
infobar-resize-event
branch
from
919c046 to
72130ae
Compare
InfoBar should really receive the resize event, to know the window width in order to do horizontal scrolling of the command line when it doesn't fit in the screen. Although currently it doesn't scroll the command line at all (see issue micro-editor#2527) and just ignores the resize event, but we should fix that anyway, so let's forward the resize event to it.
dmaluka
force-pushed
the
infobar-resize-event
branch
from
72130ae to
82706b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InfoBar should really receive the resize event, to know the window width in order to do horizontal scrolling of the command line when it doesn't fit in the screen. Although currently it doesn't scroll the command line at all (see issue #2527) and just ignores the resize event, but we should fix that anyway, so let's forward the resize event to it.