fix(super-tabs): onTabChange firing twice if page was not changed

Author: ihadeed

src/components/super-tabs-container.ts

@@ -200,7 +200,6 @@ export class SuperTabsContainer implements AfterViewInit, OnDestroy {
    * @param index {number} tab index
    */
   private setSelectedTab(index: number) {
-    console.log('Setting selected tab to: ' + index + ', from: ' + this.selectedTabIndex);
     this.tabSelect.emit({ index, changed: index !== this.selectedTabIndex });
     this.selectedTabIndex = index;
   }

src/components/super-tabs.ts

@@ -488,20 +488,16 @@ export class SuperTabs implements OnInit, AfterContentInit, AfterViewInit, OnDes
   onTabChange(index: number) {
     index = Number(index);
     if (index === this.selectedTabIndex) {
-      console.info('[a] ', index, this.selectedTabIndex);
-      // console.trace();
       this.tabSelect.emit({
         index,
         id: this._tabs[index].tabId,
         changed: false
       });
+      return;
     }
 
-    console.info('[b] ', index, this.selectedTabIndex);
 
     if (index <= this._tabs.length) {
-      console.info('[c] ', index, this.selectedTabIndex);
-      // console.trace();
 
       const currentTab: SuperTab = this.getActiveTab();
       let activeView: ViewController = currentTab.getActive();
@@ -533,15 +529,13 @@ export class SuperTabs implements OnInit, AfterContentInit, AfterViewInit, OnDes
   }
 
   onToolbarTabSelect(index: number) {
-    console.log('toolbar tab selected', index);
     if (index !== this.selectedTabIndex) {
       this.tabsContainer.slideTo(index);
     }
     this.onTabChange(index);
   }
 
   onContainerTabSelect(ev: { index: number; changed: boolean }) {
-    console.log('Container tab select fired! ', ev);
     if (ev.changed) {
       this.onTabChange(ev.index);
     }