Skip to content

Conversation

@nascimentod
Copy link

Hello,

The goal of this PR is to sanitize TOP statements that appear when using Take() in the query. This is to avoid copying over the the 'TOP' clause during the selection of the 'value part' of the commandSql.

Note: this is already in place in the EF5 and EF6 code paths, I simply copied this over to EFCORE.

@JonathanMagnan JonathanMagnan self-assigned this Jan 24, 2020
@JonathanMagnan
Copy link
Member

Hello @nascimentod ,

Thank you, we will look at it.

Best Regards,

Jon


Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework ExtensionsEntity Framework ClassicBulk OperationsDapper Plus

Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval FunctionSQL Eval Function

@JonathanMagnan
Copy link
Member

Thank you for the pull,

A new version will be released later today probably ;)

@JonathanMagnan JonathanMagnan merged commit fed66e4 into zzzprojects:master Jan 29, 2020
@nascimentod nascimentod deleted the fix/handle-take-in-batch-updates branch January 29, 2020 19:00
@nascimentod
Copy link
Author

Great, thank you!

@JonathanMagnan
Copy link
Member

Hello @nascimentod ,

Just to let you know that the latest version now contains your pull.

Thank again for letting us know.

Best Regards,

Jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants