fix(deps): bump ws to 8.21.0 to resolve GHSA-58qx-3vcg-4xpx#20
Conversation
Resolves a moderate severity advisory (uninitialized memory disclosure) in ws <=8.20.0, pulled in transitively via happy-dom. CI's npm audit step (--audit-level=moderate) was failing on main and on every open Dependabot PR because of this.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the ws dependency to version 8.21.0 in package-lock.json. The review feedback suggests managing this transitive dependency via the overrides section in package.json to ensure the security fix remains persistent and consistent with existing project practices.
| "version": "8.21.0", | ||
| "resolved": "https://registry.npmjs.org/ws/-/ws-8.21.0.tgz", | ||
| "integrity": "sha512-Vsp28b7DRcimFQvrqu2Wek3z1iYxDCWqHYB8Qsnk/S4RfaCQzPGPyBNuVjJV3cd6UiKtUtp6sNM77gWvzcCH+g==", |
There was a problem hiding this comment.
Consider adding ws to the overrides section in package.json to make this security fix persistent and consistent with how other transitive dependencies (like yaml and vite on lines 45-48) are managed in this project. Relying solely on a lockfile update for a transitive dependency can be fragile, as the fix might be lost if the lockfile is regenerated or if the parent package's requirements change.
Summary
wsfrom 8.20.0 to 8.21.0 (pulled in viahappy-dom) to resolve GHSA-58qx-3vcg-4xpx — moderate, uninitialized memory disclosure.package.jsonupdates.Why
CI's
npm run auditstep (npm audit --audit-level=moderate) is currently failing onmainand on every open Dependabot PR (#16, #17, #18, #19) because of this advisory. Those PRs are blocked despite touching unrelated dependencies. Fixing onmainunblocks all of them on the next rebase.Test plan
npm run lint— passes (only the pre-existing biome schema-version info)npm run typecheck— 0 errorsnpm run test— 4/4 passednpm run audit— 0 vulnerabilitiesnpm run build— completes