Feature/cookie consent banner #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey @muhammedsirajudeen, |
sonegs
reviewed
Apr 25, 2025
| if (consent==="all") { | ||
| onConsent(true); | ||
| } else { | ||
| const timer = setTimeout(() => { |
Collaborator
There was a problem hiding this comment.
Get out this logic to a new function. By this way, it wil be more descriptive with his title.
sonegs
reviewed
Apr 25, 2025
| <VStack align="start" flex="1"> | ||
| <Text fontWeight="bold" fontSize="md">We use cookies 🍪</Text> | ||
| <Text fontSize="sm"> | ||
| To enhance your experience on FlashNotes. By continuing, you agree to our use of cookies as outlined in our |
Collaborator
There was a problem hiding this comment.
Move this text to locales folder and take it with useTranslation react hook.
| py={4} | ||
| zIndex="toast" | ||
| boxShadow="0 -2px 10px rgba(0, 0, 0, 0.2)" | ||
| transform={isVisible ? "translateY(0)" : "translateY(100%)"} |
Collaborator
There was a problem hiding this comment.
Move this logic out of the return size to avoid mix logic with cosmetic part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented feature to provide posthog analytics based on purely on user input and persisted it as well based on user preferences #43
Picture