review: cookie consent banner

[0010aor]

This is a proposed revision of #64 (original PR by @muhammedsirajudeen).
I've tested and adjusted some things. Happy to discuss or merge if it looks good.

Thanks a lot for the contribution! Here are some things that I think we can improve:

• Uses internationalization: all consent text is now translated and localized.
• Initializes PostHog only after user consent, improving privacy compliance.
• Uses the styles defined in @/theme.tsx for consistent UI, or creates new semantic tokens.
• Maintains main.tsx as the entry point.

Please don’t forget to use Biome to format the code and set up the pre-commit tool to resolve linting issues before committing.

Great work!

[muhammedsirajudeen]

It looks great.

[muhammedsirajudeen]

shall i close #64

[sonegs]

@0010aor LGTM 🚀

[sonegs]

🚔 🚔 🚔

[sonegs]

const [acceptConsent, setAcceptConsent] = useState<boolean>(false)

But maybe you must to check the use of this state (looks like it is not neccessary)

[sonegs]

If we not use some dependency in useEffect hook, the performance will be damaged because this code will be run with each javascript change.

Checking the logic inside of this useEffect, looks like we just need to check the changes in storedConsent const, so we can add it like a dependency.

[sonegs]

Suggested change

	}, [])
	}, [storedConsent])

[0010aor]

If we not use some dependency in useEffect hook, the performance will be damaged because this code will be run with each javascript change.

Checking the logic inside of this useEffect, looks like we just need to check the changes in storedConsent const, so we can add it like a dependency.

I think in this case, the empty dependency array ([]) is intentional we just want the useEffect to run once when the component mounts. Since we’re reading from localStorage on initial load, we only need to check the user’s consent status once when the app starts.

[sonegs]

Could be interesting add a directory to save this kind of const values. Add a new directory in frontend/src/ called lib (in the future, we will a refactor of the arquitecture about that). Inside it, add a new directory called const.

In this directory, we can add a new file called analytics.ts, where we can save and export this kind of consts. Please, add a comment to explain the purpose of this const.