DT-75: Add Docker support for ClickHouse #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdotop
force-pushed
the
75-add-docker-support-for-clickhouse
branch
from
784e40f to
b6ece02
Compare
kigiri
reviewed
Oct 28, 2025
deno.json
Outdated
| "clickhouse:stop": "deno run -A tasks/deploy-clickhouse.ts --action=stop --env=dev", | ||
| "clickhouse:restart": "deno run -A tasks/deploy-clickhouse.ts --action=restart --env=dev", | ||
| "clickhouse:status": "deno run -A tasks/deploy-clickhouse.ts --action=status --env=dev", | ||
| "clickhouse:remove": "deno run -A tasks/deploy-clickhouse.ts --action=remove --env=dev" |
Member
There was a problem hiding this comment.
nit pick on cli api design, to have the action as a named argument is wierd.
-deno run -A tasks/deploy-clickhouse.ts --action=remove --env=dev"
+deno run -A tasks/deploy-clickhouse.ts remove --env=dev"Make the first position argument the action no ? feels more natural, example: git push ... and not git action=push
kigiri
reviewed
Oct 28, 2025
deno.json
Outdated
| "clickhouse:deploy": "deno run -A tasks/deploy-clickhouse.ts --env=dev", | ||
| "clickhouse:deploy:prod": "deno run -A tasks/deploy-clickhouse.ts --env=prod", | ||
| "clickhouse:stop": "deno run -A tasks/deploy-clickhouse.ts --action=stop --env=dev", | ||
| "clickhouse:restart": "deno run -A tasks/deploy-clickhouse.ts --action=restart --env=dev", |
Member
There was a problem hiding this comment.
I feel like env should be read from an environment variable. we use like APP_ENV=dev or APP_ENV=prod in tournament, I think this could apply to ?
you can pass an env argument from here too no ? like so ?
APP_ENV=dev deno run -A tasks/deploy-clickhouse.ts restartNot sure we want to do prod / not prod variant from here too, maybe this should be done by switching the env when you call or defining a .env file, maybe add the --env-file arg ?
abdotop
force-pushed
the
75-add-docker-support-for-clickhouse
branch
from
6c76f1d to
cc62f17
Compare
kigiri
reviewed
Oct 28, 2025
| -e CLICKHOUSE_PASSWORD=dev_password \ | ||
| -e CLICKHOUSE_DEFAULT_ACCESS_MANAGEMENT=1 \ | ||
| --ulimit nofile=262144:262144 \ | ||
| clickhouse/clickhouse-server:latest |
Member
There was a problem hiding this comment.
if the env file is created, you can pass the env with --env-file:
docker run -d \
--name clickhouse-dev \
-p 8123:8123 \
-p 9000:9000 \
-v ./db/clickhouse-dev:/var/lib/clickhouse \
--ulimit nofile=262144:262144 \
--env-file=.env.dev \
clickhouse/clickhouse-server:latest
abdotop
force-pushed
the
75-add-docker-support-for-clickhouse
branch
from
cc62f17 to
b6382ca
Compare
abdotop
added a commit
that referenced
this pull request
Nov 4, 2025
abdotop
added a commit
that referenced
this pull request
Nov 6, 2025
abdotop
added a commit
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ClickHouse deployment tasks and update .gitignore