Skip to content

Conversation

@abdotop
Copy link
Member

@abdotop abdotop commented Jan 9, 2026

Resolves error: Circular package dependency detected: @01edu/api -> @01edu/db -> @01edu/api.

Moved Sql type definition to @01edu/types to break the dependency cycle.

Copilot AI review requested due to automatic review settings January 9, 2026 12:17
@abdotop abdotop merged commit 69c9098 into master Jan 9, 2026
5 checks passed
@abdotop abdotop deleted the fix-circular-dependency branch January 9, 2026 12:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request resolves a circular package dependency (@01edu/api -> @01edu/db -> @01edu/api) by moving the Sql type definition from the @01edu/db package to the @01edu/types package.

  • Moved Sql type definition to @01edu/types/db
  • Updated all import references to use the new location
  • Added required @db/sqlite dependency to the types package

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
types/deno.json Added @db/sqlite dependency and new ./db export path, bumped version to 0.1.4
types/db.d.ts New file containing the Sql type definition moved from db package
deno.lock Updated lock file to include the new dependency for the types package
db/mod.ts Removed Sql type definition and imported it from @01edu/types/db
api/router.ts Updated import path for Sql type from @01edu/db to @01edu/types/db
api/dev.ts Updated import path for Sql type from @01edu/db to @01edu/types/db

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants