Skip to content

/transactions when end = 0#2147

Merged
dabasov merged 1 commit into
stagingfrom
transactions_end_zero
Feb 21, 2023
Merged

/transactions when end = 0#2147
dabasov merged 1 commit into
stagingfrom
transactions_end_zero

Conversation

@Sriep
Copy link
Copy Markdown
Contributor

@Sriep Sriep commented Feb 21, 2023

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2147 (99a84ac) into staging (eca34d6) will not change coverage.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           staging    #2147   +/-   ##
========================================
  Coverage    27.00%   27.00%           
========================================
  Files          374      374           
  Lines        61991    61991           
========================================
  Hits         16741    16741           
  Misses       43289    43289           
  Partials      1961     1961           
Flag Coverage Δ
Unit-Tests 27.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/go/0chain.net/smartcontract/storagesc/handler.go 2.25% <0.00%> (ø)
...ain.net/smartcontract/storagesc/config_settigns.go 54.76% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Copy Markdown
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain transactions_end_zero
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Copy Markdown
Collaborator

Manual system tests [success] with the following config

config value
tests skipped true
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain transactions_end_zero
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@dabasov dabasov merged commit 85f47d6 into staging Feb 21, 2023
@dabasov dabasov deleted the transactions_end_zero branch February 21, 2023 20:57
@service-0chain
Copy link
Copy Markdown
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants