Skip to content

Remove total-stored-data endpoint#2157

Merged
peterlimg merged 2 commits into
stagingfrom
remove-total-stored-data-endpoint
Feb 25, 2023
Merged

Remove total-stored-data endpoint#2157
peterlimg merged 2 commits into
stagingfrom
remove-total-stored-data-endpoint

Conversation

@aniketsingh03
Copy link
Copy Markdown

@aniketsingh03 aniketsingh03 commented Feb 24, 2023

Fixes

Fixes #2108

Changes

Remove the total-stored-data endpoint

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Copy Markdown
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli remove-total-stored-data-endpoint
zwalletcli staging
0chain remove-total-stored-data-endpoint
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@aniketsingh03 aniketsingh03 force-pushed the remove-total-stored-data-endpoint branch from 641d8ea to 9bea239 Compare February 24, 2023 11:37
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2157 (9bea239) into staging (1341b47) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           staging    #2157   +/-   ##
========================================
  Coverage    27.13%   27.13%           
========================================
  Files          374      374           
  Lines        61952    61935   -17     
========================================
- Hits         16810    16807    -3     
+ Misses       43168    43156   -12     
+ Partials      1974     1972    -2     
Flag Coverage Δ
Unit-Tests 27.13% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et/smartcontract/storagesc/benchmark_rest_tests.go 0.00% <ø> (ø)
...e/go/0chain.net/smartcontract/storagesc/handler.go 2.32% <ø> (+0.01%) ⬆️
...de/go/0chain.net/smartcontract/vestingsc/config.go 48.94% <0.00%> (-1.58%) ⬇️
...ain.net/smartcontract/storagesc/config_settigns.go 54.76% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterlimg peterlimg merged commit a84459e into staging Feb 25, 2023
@peterlimg peterlimg deleted the remove-total-stored-data-endpoint branch February 25, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove total stored data endpoint

5 participants