Add geolocation fields to the config #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
Needs to add geo-location from blobber.yaml, and pass the geo-location information to 0cahin when registering blobber. Part of 0chain/0chain#238. |
andrenerd
changed the title
andrenerd
changed the title
Contributor
Author
Contributor
|
I think we should validate longitude and latitude values.. Confirm:
|
Contributor
Author
|
@Sriep thanks. added. please, recheck. |
Sriep
suggested changes
Jun 8, 2021
Contributor
|
Merge in the latest master changes, as I think that might fix the failing to fail unit test check. |
Contributor
|
Please merge in the latest master changes. You need the fix to the unit test checks. |
Sriep
suggested changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Sriep
Need you input. Thanks.
how about to move the GeolocationConfig struct to 0chain main app, specifically here (and import from there to specific services, such as blobber):
https://github.com/0chain/0chain/blob/master/code/go/0chain.net/chaincore/config/config.go
it was also mentioned to add geolocation props to storagsc and minersc smart contracts too. does it mean, the props should be added to these structs specifically (currently they have near to zero fields)?
https://github.com/0chain/0chain/blob/ee5704d2617f42dcf857270cf73be44a9e5c523b/code/go/0chain.net/smartcontract/storagesc/sc.go#L24
https://github.com/0chain/0chain/blob/ee5704d2617f42dcf857270cf73be44a9e5c523b/code/go/0chain.net/smartcontract/minersc/sc.go#L51