Skip to content

Conversation

@andrenerd
Copy link
Contributor

@guruhubb Saswata, please, let me know, why github doesn't let me to add @stewartie4 as a reviewer? He reported the bug issue.

Copy link
Contributor

@stewartie4 stewartie4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, although this is the first time this sort of validation has been added which makes me wonder if it is missing in other places.
I'll have a look and raise a new issue if i find anything

Also see the comment re: unit tests

@andrenerd andrenerd merged commit 318a48e into master May 4, 2021
@platsko platsko deleted the fixes/validate-upload-update-meta-100 branch May 4, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/v1/file/upload: Add validation to uploadMeta/updateMeta objects

3 participants