fix(upload):added ChunkWriter feature on upload. #111 #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrenerd
approved these changes
May 10, 2021
Contributor
andrenerd
left a comment
andrenerd
left a comment
There was a problem hiding this comment.
Cool, but can some extra formatting be done? Please, check comments. Thanks.
code/go/0chain.net/blobbercore/handler/object_operation_handler.go
Outdated
Show resolved
Hide resolved
Sriep
suggested changes
May 11, 2021
Contributor
Sriep
left a comment
Sriep
left a comment
There was a problem hiding this comment.
This pr should be linked with the corresponding gosdk PR 0chain/gosdk#33
Contributor
Author
|
@Sriep please help to review them again. thanks. |
cnlangzi
changed the title
andrenerd
approved these changes
May 12, 2021
vudn95
reviewed
May 13, 2021
vudn95
left a comment
vudn95
left a comment
There was a problem hiding this comment.
LGTM. However, It's been some typo that needs to be updated.
code/go/0chain.net/blobbercore/handler/object_operation_handler.go
Outdated
Show resolved
Hide resolved
code/go/0chain.net/blobbercore/handler/object_operation_handler.go
Outdated
Show resolved
Hide resolved
code/go/0chain.net/blobbercore/handler/object_operation_handler.go
Outdated
Show resolved
Hide resolved
andrenerd
approved these changes
May 14, 2021
Sriep
approved these changes
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChunkWriterfeature onUploadHanlder.It is automate detection, and backwards compatible with old gosdk