Integration tests to object operation handlers #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senpathi
changed the title
senpathi
changed the title
# Conflicts: # code/go/0chain.net/blobbercore/convert/convert.go # code/go/0chain.net/blobbercore/handler/grpc_handler_helper_unit_test.go # code/go/0chain.net/blobbercore/handler/grpc_handler_integration_test.go
shravanshetty1
suggested changes
Jun 30, 2021
| path := strings.Split(root, `code`) | ||
|
|
||
| f, err := os.Create(path[0] + `docker.local/blobber1/files/files/exa/mpl/eId/objects/tmp/Mon/Wen/MyFile`) | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
create /tmp dir dont use docker.local
Contributor
Author
There was a problem hiding this comment.
we cannot add it outside the docker.local because it is hardcoded in blobber application to get it from there
Contributor
There was a problem hiding this comment.
please link the file where its hardcoded, I couldnt find
Contributor
Author
There was a problem hiding this comment.
it is mounted as volume in b0docker-compose.yml. And passed it as a flag. In main.go, it ie set to FsStore. line 134 in main.go
code/go/0chain.net/blobbercore/handler/grpc_handler_integration_test.go
Outdated
Show resolved
Hide resolved
code/go/0chain.net/blobbercore/handler/grpc_handler_integration_test.go
Outdated
Show resolved
Hide resolved
shravanshetty1
suggested changes
Jun 30, 2021
code/go/0chain.net/blobbercore/handler/grpc_handler_integration_test.go
Outdated
Show resolved
Hide resolved
shravanshetty1
suggested changes
Jun 30, 2021
| path := strings.Split(root, `code`) | ||
|
|
||
| f, err := os.Create(path[0] + `docker.local/blobber1/files/files/exa/mpl/eId/objects/tmp/Mon/Wen/MyFile`) | ||
| if err != nil { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #216
integration tests to