Skip to content

fix(download):fixed Access-Control-Allow-Headers for wasm sdk #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2022
Merged

fix(download):fixed Access-Control-Allow-Headers for wasm sdk #595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions code/go/0chain.net/blobbercore/handler/handler_middlewares.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,6 @@ import (
)

func useCors(h http.Handler) http.Handler {
allowedHeaders := []string{
"X-Requested-With", "Content-Type",
"X-App-Client-ID", "X-App-Client-Key", "X-App-Client-Signature",
"Access-Control-Allow-origin", "Access-Control-Request-Method",
}

allowedOrigins := []string{"*"}

allowedMethods := []string{"GET", "HEAD", "POST", "PUT",
"DELETE", "OPTIONS"}
Expand All @@ -27,8 +20,8 @@ func useCors(h http.Handler) http.Handler {
}
}()

w.Header().Add("Access-Control-Allow-Headers", strings.Join(allowedHeaders, ", "))
w.Header().Add("Access-Control-Allow-Origin", strings.Join(allowedOrigins, ", "))
w.Header().Add("Access-Control-Allow-Headers", "*")
Copy link
Contributor

@peterlimg peterlimg Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change from limited headers to allow all?

Copy link
Contributor Author

@cnlangzi cnlangzi Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. It is unnecessary to limit some headers for it

w.Header().Add("Access-Control-Allow-Origin", "*")
w.Header().Add("Access-Control-Allow-Methods", strings.Join(allowedMethods, ", "))
w.Header().Add("Access-Control-Allow-Credentials", "true")

Expand Down