Skip to content

set timeout for grpc requests #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2021
Merged

set timeout for grpc requests #78

merged 2 commits into from
Apr 19, 2021

Conversation

@andrenerd
Copy link
Contributor

@andrenerd andrenerd commented Apr 16, 2021

No description provided.

@andrenerd andrenerd linked an issue Apr 16, 2021 that may be closed by this pull request
Blobber should timeout requests that have not been responded to in over 10 seconds #30
Closed
@andrenerd
Copy link
Contributor Author

andrenerd commented Apr 17, 2021

@shravanshetty1
Shravan, are the tests consistent?
There is a test error. I'm not sure it's related to the update.

And the same error was in a pull request you merged recently:
https://github.com/0chain/blobber/pull/73/checks

@guruhubb guruhubb requested a review from Sriep April 17, 2021 23:56
@guruhubb
Copy link
Member

guruhubb commented Apr 17, 2021

@Sriep please review this

@andrenerd
Copy link
Contributor Author

andrenerd commented Apr 18, 2021 •
edited
Loading

@shravanshetty1
seems i fixed the underlying issue in tests:
84c3528

shravanshetty1
shravanshetty1 suggested changes Apr 18, 2021
View reviewed changes
@Sriep Sriep merged commit 6d9679a into master Apr 19, 2021
@platsko platsko deleted the blobber-timeout-requests-30 branch May 9, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Sriep Sriep Sriep approved these changes

@shravanshetty1 shravanshetty1 shravanshetty1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Blobber should timeout requests that have not been responded to in over 10 seconds

5 participants

@andrenerd @guruhubb @Sriep @shravanshetty1