Skip to content

Blobber consensus with unavailable sharders 34 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2021
Merged

Blobber consensus with unavailable sharders 34 #79

merged 5 commits into from
Apr 19, 2021

Conversation

@andrenerd
Copy link
Contributor

@andrenerd andrenerd commented Apr 17, 2021

No description provided.

@andrenerd andrenerd linked an issue Apr 17, 2021 that may be closed by this pull request
Blobber returns 400 with misleading error message when it fails to gain sharder consensus #34
Closed
@andrenerd andrenerd mentioned this pull request Apr 17, 2021
Closed
@guruhubb guruhubb requested a review from Sriep April 18, 2021 00:00
@andrenerd
Merge branch 'master' of https://github.com/0chain/blobber into blobb…
ae85d34 
…er-consensus-with-unavailable-sharders-34
shravanshetty1
shravanshetty1 approved these changes Apr 18, 2021
View reviewed changes
Copy link
Contributor

@shravanshetty1 shravanshetty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue title is no longer relevant. The changes include retry mechanism for sharder request, and basic refactoring. If this was the intention it looks fine.

Sriep
Sriep suggested changes Apr 18, 2021
View reviewed changes
@andrenerd
Copy link
Contributor Author

andrenerd commented Apr 18, 2021

@Sriep thanks.
cleaned up. please, review again.
ps. the long commented code blocks are legacy code. not related to the issue. so keeping them commented.

@andrenerd andrenerd requested a review from Sriep April 18, 2021 20:56
@Sriep
Copy link
Contributor

Sriep commented Apr 19, 2021 •
edited
Loading

Thanks.
Resolve review issues as they are handled (There is a resolve conversation button). If the issue is not resolved that indicates it is still a problem, blocking merging.
In future, if you want to discuss a review issue, use the reply option attached to the issue.

@andrenerd
Copy link
Contributor Author

andrenerd commented Apr 19, 2021

@Sriep
oops, sorry.
done. could it be merged now?

@Sriep Sriep merged commit dde8eca into master Apr 19, 2021
@Sriep Sriep deleted the blobber-consensus-with-unavailable-sharders-34 branch April 19, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Sriep Sriep Sriep approved these changes

@shravanshetty1 shravanshetty1 shravanshetty1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Blobber returns 400 with misleading error message when it fails to gain sharder consensus

4 participants

@andrenerd @Sriep @shravanshetty1