Skip to content

fix(thumbnail):fixed assertions for thumbnail operation #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jan 28, 2022
Merged

fix(thumbnail):fixed assertions for thumbnail operation #173

merged 24 commits into from
Jan 28, 2022

Conversation

@cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Jan 26, 2022 •
edited
Loading

changes

  • improved image file generator
  • fixed all assertions for thumbnail

@cnlangzi cnlangzi marked this pull request as draft January 26, 2022 12:03
@service-0chain
Copy link
Contributor

service-0chain commented Jan 26, 2022

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/fix_thumbnail_assertion
gosdk NOT OVERRIDDEN
zboxcli fix/update_sha1_with_sha256_for_file_hash
zwalletcli staging
0chain staging
blobber fix/update_sha1_with_sha256_for_file_hash
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

This was referenced Jan 26, 2022
Merged
Merged
Merged
@service-0chain
Copy link
Contributor

service-0chain commented Jan 26, 2022

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/fix_thumbnail_assertion
gosdk NOT OVERRIDDEN
zboxcli fix/update_sha1_with_sha256_for_file_hash
zwalletcli staging
0chain staging
blobber fix/update_sha1_with_sha256_for_file_hash
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

service-0chain commented Jan 26, 2022

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/fix_thumbnail_assertion
gosdk fix/update_sha1_with_sha256_for_file_hash
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/update_sha1_with_sha256_for_file_hash
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi marked this pull request as ready for review January 26, 2022 15:03
Kishan-Dhakan
Kishan-Dhakan reviewed Jan 26, 2022
View reviewed changes
stewartie4
stewartie4 reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@stewartie4 stewartie4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit a6708ba into master Jan 28, 2022
@Kishan-Dhakan Kishan-Dhakan deleted the fix/fix_thumbnail_assertion branch January 4, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@stewartie4 stewartie4 stewartie4 approved these changes

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cnlangzi @service-0chain @stewartie4 @Kishan-Dhakan @kushthedude