Python 3 support

[wmayner]

This library looks awesome. Any chance of it being updated to work with Python 3?

Happy to help if I can! 😃

[bombela]

Hey, I recently started a port to python3. Most of the work on zerorpc is only str vs unicode stuff. The really difficult part is to get gevent on python3. There is few fork out there, and I even started my own that adds few missing things. I need to take the time to update bombela/{zerorpc-python, gevent} with my latest work, so you can participate!

[wmayner]

Awesome. I made a bit of progress: I installed gevent using @fantix's fork, which seemed to work (you need to explicitly install Cython first). The other dependencies installed easily. Then I installed your fork of zeropc, but when I try to import it, I get this:

Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/Users/will/.virtualenvs/rpc-pyphi/lib/python3.4/site-packages/zerorpc/__init__.py", line 29, in <module>
 from .context import *
  File "/Users/will/.virtualenvs/rpc-pyphi/lib/python3.4/site-packages/zerorpc/context.py", line 29, in <module>
    import gevent_zmq as zmq
ImportError: No module named 'gevent_zmq'

Yet when I go to the /Users/will/.virtualenvs/rpc-pyphi/lib/python3.4/site-packages/zerorpc/ directory and attempt to import context directly from there, I don't get the same error.

Any ideas?

[wmayner]

I think I found it—in several of the files, relative imports are being performed without the period to indicate that they're relative. Not totally sure if that's normally a problem, but changing them to explicitly relative imports seemed to fix it. I'll put in a PR in a minute.

[dvreed]

@wmayner, any update on that PR? I'd love to be able to use this with python 3.

[eranimo]

👍 I also need this. What can be done to get this faster?

[alekibango]

Today, python3 setup.py install worked for me, which gave me hope...
But:
zerorpc
still leads to error mentioned above:

    import gevent_zmq as zmq
ImportError: No module named 'gevent_zmq'

[mehdisadeghi]

Have you tried this:

import zmq.green as zmq

On 10 April 2015 at 16:19, David Pravec notifications@github.com wrote:

Today, python3 setup.py install worked for me, which gave me hope...
But:
zerorpc
still leads to error mentioned above:

import gevent_zmq as zmq

ImportError: No module named 'gevent_zmq'

—
Reply to this email directly or view it on GitHub
#108 (comment)
.

[alekibango]

@mehdisadeghi thansk for this hint.
i tried that, edited few python files around... fixing zmq.green, exceptions, print statements,
and result is this (runs, but does not work as expected):

zerorpc --server tcp://0.0.0.0:2345 time
connecting to "tcp://0.0.0.0:2345"
serving "time"
Traceback (most recent call last):
  File "/home/dp/test/zerorpc3/lib/python3.4/site-packages/gevent-1.1-py3.4-linux-x86_64.egg/gevent/greenlet.py", line 340, in run
    result = self._run(*self.args, **self.kwargs)
  File "/home/dp/test/zerorpc3/lib/python3.4/site-packages/zerorpc-0.4.4-py3.4.egg/zerorpc/events.py", line 55, in _sender
    for parts in self._send_queue:
TypeError: iter() returned non-iterator of type 'Channel'
<Greenlet at 0x7f764b2666d0: <bound method Sender._sender of <zerorpc.events.Sender object at 0x7f7646ec2e80>>> failed with TypeError

So, still not working, now i need to figure out how to make Channel work. Here is my fork, where i am trying to achieve python3 compatibility (not both, just py3 for now)

[bombela]

I did the same thing, trying to get py3 only first and got most test to
pass, but I had to modify gevent and it was few month ago. I will see if I
can take some time to upload all my updates but i highly doubt that it will
work.

On Wed, Apr 22, 2015, 08:15 David Pravec notifications@github.com wrote:

@mehdisadeghi https://github.com/mehdisadeghi thansk for this hint.
i tried that, edited few python files around... fixing zmq.green,
exceptions, print statements,
and result is this (runs, but does not work as expected):

zerorpc --server tcp://0.0.0.0:2345 time
connecting to "tcp://0.0.0.0:2345"
serving "time"
Traceback (most recent call last):
File "/home/dp/test/zerorpc3/lib/python3.4/site-packages/gevent-1.1-py3.4-linux-x86_64.egg/gevent/greenlet.py", line 340, in run
result = self._run(_self.args, *_self.kwargs)
File "/home/dp/test/zerorpc3/lib/python3.4/site-packages/zerorpc-0.4.4-py3.4.egg/zerorpc/events.py", line 55, in _sender
for parts in self._send_queue:
TypeError: iter() returned non-iterator of type 'Channel'
<Greenlet at 0x7f764b2666d0: <bound method Sender._sender of <zerorpc.events.Sender object at 0x7f7646ec2e80>>> failed with TypeError

So, still not working, now i need to figure out how to make Channel work. Here
is my fork https://github.com/alekibango/zerorpc-python, where i am
trying to achieve python3 compatibility (not both, just py3 for now)

—
Reply to this email directly or view it on GitHub
#108 (comment)
.

[TDaltonC]

What about switching over to asynchIO? I'm sure that sounds extreme, and I don't know the details of how 0rpc is using gevent, but reading the years of almost-but-not-quite py3 compatibility documented in on that repo, I think that py3 support is not a priority for @denik and @fantix.

[bombela]

asyncio is really a good idea. It's probably the best way forward now that you mention it. This might require a new 'zerorpc-python-asyncio' package and a different repository altogether, but this is probably better than having a fork of gevent + bad interop with all asyncio libs of python>=3.4.

[alekibango]

Please do not forget to consider some limitations of aiozmq (asyncio zeromq integration):

• You obviously cannot use ipc://name schema for endpoint
• aiozmq`s loop aiozmq.ZmqEventLoop is built on top of select system call, so it’s not fast comparing to asyncio.ProactorEventLoop and it doesn’t support subprocesses.

While we all can probably live without ipc://name schema, the second point is making me little nervous..

[bombela]

Aren't the limitation for MS Windows?

[TDaltonC]

Gevent is not python3 compatible.

gevent/gevent#38 (comment)