Skip to content

build: fix docs.rs build#116

Merged
0x676e67 merged 1 commit intomasterfrom
docs
Feb 13, 2026
Merged

build: fix docs.rs build#116
0x676e67 merged 1 commit intomasterfrom
docs

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build issue encountered specifically when the project is being built by docs.rs. It introduces a conditional check within the build script to bypass a particular symbol prefixing step during docs.rs builds, thereby ensuring that documentation can be generated successfully without impacting the standard build process for other targets.

Highlights

  • Docs.rs Build Fix: The build process has been updated to prevent the prefix_symbols function from executing when building for docs.rs, resolving a build failure specific to the documentation generation environment.
Changelog
  • boring-sys/build/main.rs
    • Added a conditional check to prevent the prefix_symbols function from running when the docs_rs environment variable is set, which is typically the case during docs.rs builds.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@0x676e67 0x676e67 merged commit 7a7977b into master Feb 13, 2026
25 checks passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes the docs.rs build by skipping the symbol prefixing step when building for that environment. The change is correct and necessary, as the native libraries that would be prefixed are not built on docs.rs. The implementation is sound and consistent with how other build steps are handled for docs.rs. I have no further feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant