Websocket Support - timeout on recv() in BlockingWebsocket

[johnraysimpson]

Is your feature request related to a problem? Please describe.
Occasionally while executing a BlockingWebsocket there is the potential of hanging on the .recv() method

Describe the solution you'd like
timeout functionality on the .recv() method

Describe alternatives you've considered
N/A

Additional context
N/A

Many thanks! Love this library

[0x676e67]

Could you check what the default timeout is for some other Python WebSocket clients?

[MPatersonSoftware]

Hey, we're working on the same project so I thought I'd answer for John for you.

The 'websockets' package leaves the timeout as None, but exposes a parameter to set it in the recv function.

This is somewhat the same in websocket-client where the timeout is global across the connection and set during connection creation, but with None as a default.

[0x676e67]

This is the timeout of establishing the connection. What we should need to set is the read and write timeout of websocket. I think it is necessary to set the default read and write timeout in the global setting or optional read and write timeout for each individual call.

[MPatersonSoftware]

In the websockets package the timeout is the read timeout on recv

timeout is None, block until a message is received. If timeout is set, wait up to timeout seconds for a message to be received and return it, else raise TimeoutError.

The defaut behaviour of the websockets package that we've witnessed also matches this, in that the recv function call will just block indefinitely if no timeout is provided and no message is received.