Skip to content

perf(ws): prevent deep copy of message data #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0x676e67 merged 1 commit into from
Mar 12, 2025
Merged

perf(ws): prevent deep copy of message data #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/async_impl/ws/message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use pyo3_stub_gen::derive::{gen_stub_pyclass, gen_stub_pymethods};
use rquest::Utf8Bytes;

use crate::{
buffer::{Buffer, BytesBuffer, PyBufferProtocol},
buffer::{BytesBuffer, PyBufferProtocol},
error::wrap_rquest_error,
typing::Json,
};
Expand Down Expand Up @@ -37,13 +37,13 @@ impl Message {
#[getter]
pub fn data<'py>(&self, py: Python<'py>) -> Option<Bound<'py, PyAny>> {
let bytes = match &self.0 {
rquest::Message::Text(text) => text.as_bytes(),
rquest::Message::Text(text) => text.clone().into(),
rquest::Message::Binary(bytes)
| rquest::Message::Ping(bytes)
| rquest::Message::Pong(bytes) => bytes,
| rquest::Message::Pong(bytes) => bytes.clone(),
_ => return None,
};
Buffer::new(bytes.to_vec()).into_bytes_ref(py).ok()
BytesBuffer::new(bytes).into_bytes_ref(py).ok()
}

/// Returns the text content of the message if it is a text message.
Expand Down Expand Up @@ -171,7 +171,7 @@ impl Message {
#[pyo3(signature = (text))]
#[inline(always)]
pub fn from_text(text: PyBackedStr) -> Self {
let msg = rquest::Message::Text(rquest::Utf8Bytes::from(text.as_ref() as &str));
let msg = rquest::Message::text(text.as_ref() as &str);
Message(msg)
}

Expand Down