Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the
ClientandClientParamsstructures to add support for cookie store options. The most important changes include adding thecookie_storeoption to theClientParamsstructure and ensuring it is properly applied in theClientimplementation.Enhancements to
ClientandClientParams:src/client.rs: Added the application of thecookie_storeoption in theClientimplementation.src/param/client.rs: Added thecookie_storefield to theClientParamsstructure with appropriate documentation and getter method.src/param/client.rs: Updated theFromPyObjectimplementation forClientParamsto extract thecookie_storeoption.