Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on refactoring error handling throughout the codebase by consolidating various error types into a single
Errortype. The changes involve updating error handling in multiple files and functions to use this new consolidated error type.Error Handling Refactor:
src/async_impl/client.rs: Replaced specific error handling functions likewrap_rquest_errorandwrap_url_parse_errorwith the consolidatedErrortype. [1] [2] [3] [4] [5] [6] [7]src/async_impl/request.rs: Updated error handling in request functions to use theError::RquestErrortype. [1] [2] [3]src/async_impl/response/http.rs: Modified response handling to replace specific error functions with theErrortype. [1] [2] [3] [4] [5] [6] [7] [8]src/async_impl/response/ws/message.rs: Refactored WebSocket message handling to use the newErrortype for error handling. [1] [2] [3] [4]src/async_impl/response/ws/mod.rs: Updated WebSocket module to use the consolidatedErrortype for various error scenarios. [1] [2] [3] [4] [5]src/blocking/response/http.rs: Changed blocking response handling to use theError::RquestErrortype. [1] [2] [3] [4] [5] [6]src/blocking/response/ws.rs: Refactored blocking WebSocket response handling to use the newErrortype.