Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to support building manylinux wheels, updates to the README for clarity, and minor code cleanup in an example file. The most important changes are summarized below:
Support for manylinux wheels:
.github/build.sh: Added an optionalmanylinuxargument to the build script and modified theMATURIN_CMDto support building manylinux wheels when this argument is provided. [1] [2].github/workflows/ci.yml: Updated the CI workflow to pass themanylinuxargument to the build script.Documentation updates:
README.md: Updated the description of Linux wheel compatibility to specify GNU-GLIBC-2.34.Code cleanup:
examples/client.py: Removed an unnecessary import statement.