Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances proxy support in WebSocket requests by replacing string‐based proxy definitions with a more structured proxy type. Key changes include:
- Changing the proxy type from a string (or PyBackedStr) to ProxyExtractor/Proxy in parameters and documentation.
- Updating docstrings and type annotations across async and blocking clients.
- Bumping the rquest dependency version and enabling new proxy-related features.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/typing/param/ws.rs | Updated the proxy field to use a ProxyExtractor, reflecting the new proxy design. |
| src/lib.rs | Revised documentation to refer to Proxy rather than a string type. |
| src/blocking/client.rs | Updated proxy annotations in doc comments to use the new Proxy type. |
| src/async_impl/request.rs | Modified macro usage for applying proxy options with the new type. |
| src/async_impl/client.rs | Updated doc comments for proxy usage in async client methods. |
| rnet.pyi | Revised proxy type in type hints and method signatures. |
| Cargo.toml | Upgraded rquest dependency and added features to support enhanced proxy functionality. |
Comments suppressed due to low confidence (3)
src/typing/param/ws.rs:15
- Consider aligning the proxy type naming with the rest of the codebase; either rename 'ProxyExtractor' to 'Proxy' or update the documentation to clearly indicate the distinction.
pub proxy: Option<ProxyExtractor>,
src/async_impl/request.rs:200
- Verify that the 'apply_if_some_inner' macro correctly handles the conversion for 'params.proxy' and maintains consistency with previous behavior.
apply_option!(apply_if_some_inner, builder, params.proxy, proxy);
Cargo.toml:44
- Double-check that the updated rquest version and the addition of 'cookies-preserve-order' and 'cookies-multiple' features are fully compatible with the rest of the codebase.
rquest = { version = "5.1.0", features = [
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.