Skip to content

feat(proxy): enhanced websocket request level proxy definition#175

Merged
0x676e67 merged 2 commits intomainfrom
feat
Mar 30, 2025
Merged

feat(proxy): enhanced websocket request level proxy definition#175
0x676e67 merged 2 commits intomainfrom
feat

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances proxy support in WebSocket requests by replacing string‐based proxy definitions with a more structured proxy type. Key changes include:

  • Changing the proxy type from a string (or PyBackedStr) to ProxyExtractor/Proxy in parameters and documentation.
  • Updating docstrings and type annotations across async and blocking clients.
  • Bumping the rquest dependency version and enabling new proxy-related features.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/typing/param/ws.rs Updated the proxy field to use a ProxyExtractor, reflecting the new proxy design.
src/lib.rs Revised documentation to refer to Proxy rather than a string type.
src/blocking/client.rs Updated proxy annotations in doc comments to use the new Proxy type.
src/async_impl/request.rs Modified macro usage for applying proxy options with the new type.
src/async_impl/client.rs Updated doc comments for proxy usage in async client methods.
rnet.pyi Revised proxy type in type hints and method signatures.
Cargo.toml Upgraded rquest dependency and added features to support enhanced proxy functionality.
Comments suppressed due to low confidence (3)

src/typing/param/ws.rs:15

  • Consider aligning the proxy type naming with the rest of the codebase; either rename 'ProxyExtractor' to 'Proxy' or update the documentation to clearly indicate the distinction.
pub proxy: Option<ProxyExtractor>,

src/async_impl/request.rs:200

  • Verify that the 'apply_if_some_inner' macro correctly handles the conversion for 'params.proxy' and maintains consistency with previous behavior.
apply_option!(apply_if_some_inner, builder, params.proxy, proxy);

Cargo.toml:44

  • Double-check that the updated rquest version and the addition of 'cookies-preserve-order' and 'cookies-multiple' features are fully compatible with the rest of the codebase.
rquest = { version = "5.1.0", features = [

@0x676e67 0x676e67 merged commit 6a7856e into main Mar 30, 2025
17 checks passed
@0x676e67 0x676e67 deleted the feat branch March 30, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants