Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adapts header handling by introducing support for multiple value sequences of key mapping. Key changes include:
- Exposing a new iterator (HeaderMapValuesIter) in the public API.
- Adding a new method get_all to retrieve all header values for a given key.
- Updating imports and class registrations to support the new iterator.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/typing/mod.rs | Reordered exports and exposed HeaderMapValuesIter to support multiple value sequences. |
| src/typing/headers.rs | Added get_all and refactored items; implemented the new HeaderMapValuesIter iterator. |
| src/lib.rs | Updated imports and registered HeaderMapValuesIter with the module. |
Comments suppressed due to low confidence (1)
src/typing/headers.rs:165
- Using pop() in the next method returns values in reverse order compared to their original insertion order; consider using an index-based iteration approach if preserving the natural order is required.
slf.inner.pop()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.