Skip to content

feat(header): adapt multiple value sequences of key mapping#179

Merged
0x676e67 merged 2 commits intomainfrom
feat
Apr 3, 2025
Merged

feat(header): adapt multiple value sequences of key mapping#179
0x676e67 merged 2 commits intomainfrom
feat

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

@0x676e67 0x676e67 commented Apr 3, 2025

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adapts header handling by introducing support for multiple value sequences of key mapping. Key changes include:

  • Exposing a new iterator (HeaderMapValuesIter) in the public API.
  • Adding a new method get_all to retrieve all header values for a given key.
  • Updating imports and class registrations to support the new iterator.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/typing/mod.rs Reordered exports and exposed HeaderMapValuesIter to support multiple value sequences.
src/typing/headers.rs Added get_all and refactored items; implemented the new HeaderMapValuesIter iterator.
src/lib.rs Updated imports and registered HeaderMapValuesIter with the module.
Comments suppressed due to low confidence (1)

src/typing/headers.rs:165

  • Using pop() in the next method returns values in reverse order compared to their original insertion order; consider using an index-based iteration approach if preserving the natural order is required.
slf.inner.pop()

@0x676e67 0x676e67 merged commit 2f79c3d into main Apr 3, 2025
17 checks passed
@0x676e67 0x676e67 deleted the feat branch April 3, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants