Conversation
kreedzZhao
pushed a commit
to kreedzZhao/rnet
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of request parameters and macro definitions in the Rust codebase. The most important changes include adding support for redirect options, moving a macro definition, and updating the
RequestParamsstruct and its implementation.Improvements to request parameters:
src/client.rs: Added support for redirect options in theexecute_requestfunction by applying theallow_redirectsparameter.src/param/req.rs: Updated theRequestParamsstruct to include anallow_redirectsfield and modified theFromPyObjectimplementation to extract this option. [1] [2]Macro definition changes:
src/lib.rs: Removed thedefine_constantsmacro definition.src/types/mod.rs: Added thedefine_constantsmacro definition to this module.