Skip to content

feat(cookie): retrieve all cookies from the cookie jar#276

Merged
0x676e67 merged 1 commit intomainfrom
feat
Aug 10, 2025
Merged

feat(cookie): retrieve all cookies from the cookie jar#276
0x676e67 merged 1 commit intomainfrom
feat

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

close: #235

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to retrieve all cookies from a cookie jar by implementing a get_all() method. The changes include switching from cookie_crate::Cookie to cookie_store::RawCookie for better compatibility with the cookie store operations.

  • Added get_all() method to the Jar class to retrieve all stored cookies
  • Refactored cookie handling to use RawCookie instead of cookie_crate::Cookie
  • Updated all cookie-related methods to use Python's allow_threads for better concurrency

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/cookie.rs Implements the core get_all() functionality and refactors cookie type usage
python/rnet/cookie.pyi Adds type hint for the new get_all() method
tests/cookie_test.py Adds comprehensive test coverage for the new get_all() functionality

@0x676e67 0x676e67 merged commit 1d96f8b into main Aug 10, 2025
16 checks passed
@0x676e67 0x676e67 deleted the feat branch August 10, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get all cookies from a client

2 participants