Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to retrieve all cookies from a cookie jar by implementing a get_all() method. The changes include switching from cookie_crate::Cookie to cookie_store::RawCookie for better compatibility with the cookie store operations.
- Added
get_all()method to theJarclass to retrieve all stored cookies - Refactored cookie handling to use
RawCookieinstead ofcookie_crate::Cookie - Updated all cookie-related methods to use Python's
allow_threadsfor better concurrency
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/cookie.rs |
Implements the core get_all() functionality and refactors cookie type usage |
python/rnet/cookie.pyi |
Adds type hint for the new get_all() method |
tests/cookie_test.py |
Adds comprehensive test coverage for the new get_all() functionality |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #235