Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the stream iterator implementation to use channel-based iteration instead of mutex-protected streams, improving performance by eliminating lock contention.
- Replaces
Arc<Mutex<Option<BytesStream>>>withmpsc::Receiver<wreq::Result<Bytes>> - Spawns a background task to feed stream data into the channel
- Updates error handling to provide more specific messages for channel states
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/error.rs | Updates StopAsyncIteration error to include TryRecvError for better channel error handling |
| src/client/response/stream.rs | Refactors Streamer to use MPSC channels instead of mutex-protected streams |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.