Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to add support for a base URL parameter in the
Clientclass, enhance the WebSocket documentation, and update the related Rust structures. The most important changes include adding thebase_urlparameter, updating theClientclass, and adding an example script demonstrating the new functionality.Support for Base URL Parameter:
rnet.pyi: Addedbase_urlas an optional string parameter to theClientParamsclass.src/param/client.rs: Addedbase_urlfield to theClientParamsstruct and updated theFromPyObjectimplementation to extract this new parameter. [1] [2]Enhancements to WebSocket Documentation:
rnet.pyi: Enhanced thewebsocketmethod documentation in theClientclass to include arguments, return values, and examples.Example Script:
examples/base_url.py: Added a new example script demonstrating how to use thebase_urlparameter with theClientclass and perform a streaming request.