Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the functionality and maintainability of the
rnetlibrary. The changes focus on enhancing theClientclass, adding new functionality, and improving error handling.Enhancements to
Clientclass:get_cookies,set_cookies, andupdateto theClientclass inrnet.pyito manage cookies and update client parameters.Clientstruct to useArcSwapfor thread-safe updates and added new methods to retrieve user agent and headers insrc/client.rs. [1] [2]loadmethod ofArcSwapfor better performance and thread safety insrc/client.rs. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Error handling improvements:
wrap_invali_header_value_errorandwrap_url_parse_errorinsrc/error.rsto provide more specific error messages.New parameter class:
UpdateClientParamsclass inrnet.pyiandsrc/param/client.rsto encapsulate parameters for updating the client. [1] [2]Dependency updates:
urldependency inCargo.tomlto support URL parsing.