Skip to content

perf(json): zero-copy string deserialization#392

Merged
0x676e67 merged 2 commits intomainfrom
perf
Oct 17, 2025
Merged

perf(json): zero-copy string deserialization#392
0x676e67 merged 2 commits intomainfrom
perf

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

No description provided.

@0x676e67 0x676e67 requested a review from Copilot October 17, 2025 16:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces zero-copy string deserialization for JSON values to improve performance when handling JSON data containing string values from Python.

  • Introduces a new JsonString enum that can hold either Python-backed strings or standard Rust strings
  • Updates the Json enum to use JsonString instead of String for object keys and string values
  • Moves import statement to improve organization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/client/body/mod.rs Reorganizes imports by moving Runtime import to maintain alphabetical order
src/client/body/json.rs Implements zero-copy string handling with new JsonString enum and associated trait implementations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@0x676e67 0x676e67 merged commit dabcf28 into main Oct 17, 2025
11 of 32 checks passed
@0x676e67 0x676e67 deleted the perf branch October 17, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants