Skip to content

refactor(core): reduce dependency on futures#393

Merged
0x676e67 merged 6 commits intomainfrom
stream
Oct 19, 2025
Merged

refactor(core): reduce dependency on futures#393
0x676e67 merged 6 commits intomainfrom
stream

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

No description provided.

@0x676e67 0x676e67 requested a review from Copilot October 19, 2025 01:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase to reduce dependency on the futures crate by replacing it with futures-util and tokio alternatives. The main goal is to minimize external dependencies while maintaining the same functionality.

  • Replaced futures::channel::{mpsc, oneshot} with tokio::sync::{mpsc, oneshot}
  • Implemented a custom ReceiverStream wrapper to provide Stream trait functionality
  • Updated method signatures to use futures_util::Stream instead of futures::Stream

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/rt/sync.rs Implements custom ReceiverStream and updates channel usage to tokio
src/rt/mod.rs Updates imports and return types to use new stream implementation
Cargo.toml Comments out the futures dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

0x676e67 and others added 2 commits October 19, 2025 09:21
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@0x676e67 0x676e67 merged commit 0596997 into main Oct 19, 2025
32 checks passed
@0x676e67 0x676e67 deleted the stream branch October 19, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants