Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to reduce dependency on the futures crate by replacing it with futures-util and tokio alternatives. The main goal is to minimize external dependencies while maintaining the same functionality.
- Replaced
futures::channel::{mpsc, oneshot}withtokio::sync::{mpsc, oneshot} - Implemented a custom
ReceiverStreamwrapper to provideStreamtrait functionality - Updated method signatures to use
futures_util::Streaminstead offutures::Stream
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/rt/sync.rs | Implements custom ReceiverStream and updates channel usage to tokio |
| src/rt/mod.rs | Updates imports and return types to use new stream implementation |
| Cargo.toml | Comments out the futures dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.