Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for dictionary types in query parameters by introducing a new Query type alias and refactoring the form data structure. The change allows query parameters to be specified as either a map (dictionary) or a list of key-value tuples, similar to how form data is handled.
Key Changes:
- Introduced a
Querytype that reuses the existingFormenum structure - Renamed
Form::Tuplevariant toForm::Listfor better clarity - Updated the
Requeststruct to use the newQuerytype instead of a simple vector extractor
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/client/req.rs | Updated query field type from Extractor<Vec> to Query and added import for the new query module |
| src/client/query.rs | Introduced new Query type alias that reuses the Form enum |
| src/client/body/form.rs | Renamed Tuple variant to List for better semantic clarity |
| src/client.rs | Added query module to the client module exports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.