Skip to content

feat(request): support dict type in query data#399

Merged
0x676e67 merged 2 commits intomainfrom
feat2
Oct 24, 2025
Merged

feat(request): support dict type in query data#399
0x676e67 merged 2 commits intomainfrom
feat2

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

No description provided.

@0x676e67 0x676e67 requested a review from Copilot October 24, 2025 14:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for dictionary types in query parameters by introducing a new Query type alias and refactoring the form data structure. The change allows query parameters to be specified as either a map (dictionary) or a list of key-value tuples, similar to how form data is handled.

Key Changes:

  • Introduced a Query type that reuses the existing Form enum structure
  • Renamed Form::Tuple variant to Form::List for better clarity
  • Updated the Request struct to use the new Query type instead of a simple vector extractor

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/client/req.rs Updated query field type from Extractor<Vec> to Query and added import for the new query module
src/client/query.rs Introduced new Query type alias that reuses the Form enum
src/client/body/form.rs Renamed Tuple variant to List for better semantic clarity
src/client.rs Added query module to the client module exports

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants