Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the body handling code to consolidate stream types and improve code organization through formatting and simplification.
Key Changes:
- Merged
SyncStreamandAsyncStreaminto a singlePyStreamenum - Changed
ValueandBodyenums to usePyBackedStr/PyBackedBytesdirectly with derive macros instead of pre-convertedBytes - Updated file paths in examples to be relative to the correct directory
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/client/body/multipart.rs | Consolidated stream types in Value enum, moved FromPyObject implementation to derive macro |
| src/client/body.rs | Merged SyncStream and AsyncStream into PyStream enum, simplified Body enum with derive macro |
| python/examples/multipart.py | Corrected file paths to remove incorrect "../" prefix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.