Skip to content

feat(emulation): update emulation device enums#475

Merged
0x676e67 merged 2 commits intomainfrom
feat
Dec 31, 2025
Merged

feat(emulation): update emulation device enums#475
0x676e67 merged 2 commits intomainfrom
feat

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the system's emulation capabilities by incorporating a wide array of new browser versions across Chrome, Edge, Firefox, and Safari. It also includes an essential update to the wreq-util dependency and a minor, yet impactful, refactoring to streamline the handling of original header names within the codebase.

Highlights

  • Dependency Update: The wreq-util dependency has been updated to version 3.0.0-rc.9.
  • Expanded Emulation Devices: New browser versions for Chrome, Edge, Firefox, and Safari have been added to the emulation device enums in both Rust and Python.
  • Header Name Handling Refinement: The conversion logic for OrigHeaderName to PyBuffer has been simplified and improved for better maintainability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the available device emulations by adding new versions for Chrome, Edge, Firefox, and Safari. It also bumps the wreq-util dependency to support these additions and includes a minor refactoring for handling original header names.

My review has identified a few minor issues:

  • A duplicated entry for Edge135 and some trailing whitespace in the README.md file.
  • An inconsistent naming convention for a new Safari iPad emulation enum in both the Python and Rust source files.

I've provided suggestions to correct these points. Otherwise, the changes look good.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant