feat(cookie): consolidate cookie methods into a unified add()

[0x676e67]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant API improvement for cookie management within the rnet library by consolidating disparate cookie addition methods into a single, more versatile add() function. This change aims to simplify the developer experience by providing a unified interface for handling both Cookie objects and string representations. The necessary modifications have been propagated to the Rust backend to ensure full functionality, and older methods are now deprecated to encourage adoption of the new API. Additionally, the PR includes minor documentation updates and addresses a typo in the redirect module's examples.

Highlights

• Unified Cookie Addition API: The Jar class now features a single add() method in Python, capable of accepting both Cookie objects and raw cookie strings, streamlining the process of adding cookies.
• Method Deprecation: The previously separate add_cookie() and add_cookie_str() methods in python/rnet/cookie.py have been marked as deprecated, guiding users towards the new unified add() method.
• Rust Backend Integration: The underlying Rust implementation (src/cookie.rs) has been updated with a new PyCookie enum and a corresponding add method to seamlessly support the Python-side API consolidation.
• Documentation Refinements & Typo: Minor documentation adjustments were made in python/rnet/redirect.py, including an example correction for Policy.limited() and a notable typo (Policy.stom instead of Policy.custom) in another example.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request consolidates the add_cookie and add_cookie_str methods into a unified add() method, which is a nice API improvement. The implementation seems correct. However, I found a typo in an example within a docstring in python/rnet/redirect.py. More importantly, the new add() method is not covered by tests. The existing tests for cookie adding still use the now-deprecated methods. It is crucial to add tests for the new functionality to ensure it works as expected with both Cookie objects and cookie strings.