refactor(response): refactor TlsInfo extension wrapper

[0x676e67]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the way TLS connection information is exposed through the Response object. It introduces a new TlsInfo wrapper class, which now holds details such as the peer certificate. This change moves the peer_certificate attribute from being a direct property of Response to a method accessible via the Response.tls_info object, providing a more organized and extensible structure for handling TLS-related data. Additionally, the need to explicitly enable tls_info during client initialization has been removed, simplifying its usage.

Highlights

• API Refactoring for TLS Information: The Response object no longer directly exposes peer_certificate. Instead, a new tls_info attribute of type TlsInfo is introduced, which then provides the peer_certificate() method.
• Introduction of TlsInfo Class: A dedicated TlsInfo class has been added to encapsulate TLS connection details, providing a more structured way to access information like the peer certificate.
• Simplified Client Initialization: The tls_info=True parameter is no longer required when initializing a Client to enable TLS information retrieval, streamlining client setup.
• Updated Examples and Tests: All relevant examples and test cases have been updated to reflect the new API for accessing TLS information.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors how TLS information is exposed on the Response object by introducing a TlsInfo wrapper class. The changes in the Rust and Python code are consistent and correctly implement this refactoring.

However, I've identified a critical issue that will cause test failures. The tls_info parameter has been removed from the rnet.Client constructor, but several test files still use it when creating client instances. These instantiations are not part of the current diff, so I've added specific comments where possible, but a broader fix is needed across the test suite.

Specifically, please remove the tls_info=True argument from rnet.Client calls in the following files to prevent TypeError exceptions:

• tests/request_test.py on line 6
• tests/response_test.py on line 6
• tests/tls_test.py on line 20

Addressing these will ensure the tests pass and validate the refactoring.