perf(identity): optimize mTLS identity creation performance

[0x676e67]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the performance of mTLS identity creation by optimizing how byte and string data is transferred between Python and Rust. By leveraging PyBackedBytes and PyBackedStr, the changes eliminate unnecessary data copies, leading to more efficient and faster identity generation processes within the tls module.

Highlights

• Performance Optimization: Introduced PyBackedBytes and PyBackedStr from pyo3 to optimize the handling of byte and string data passed from Python to Rust, specifically for mTLS identity creation.
• API Signature Update: Updated the from_pkcs12_der static method to accept PyBackedBytes for the buffer and PyBackedStr for the password, reducing data copying overhead.
• API Signature Update: Modified the from_pkcs8_pem static method to accept PyBackedBytes for both the certificate buffer and the key, further minimizing data duplication.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request optimizes mTLS identity creation by using PyBackedBytes and PyBackedStr to avoid data copies from Python to Rust. The changes in from_pkcs12_der and from_pkcs8_pem are correctly implemented for zero-copy data passing. The code is sound and a good performance improvement. I would suggest adding unit tests for these modified functions to verify their correctness and prevent future regressions.