Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several enhancements to the WebSocket configuration in the
src/client.rsandsrc/param/websocket.rsfiles. The changes focus on adding new configuration options for WebSocket parameters and ensuring they are properly applied during WebSocket requests.Enhancements to WebSocket configuration:
WebSocketParamsstructure, includingwrite_buffer_size,max_write_buffer_size,max_message_size,max_frame_size, andaccept_unmasked_frames. These options provide more control over WebSocket behavior, such as buffer sizes and message handling.FromPyObjectimplementation forWebSocketParamsto extract the new configuration options from Python objects. This ensures that the new parameters can be set from Python code.execute_websocket_requestfunction insrc/client.rsto apply the new WebSocket configuration options using theapply_option!macro. This change integrates the new parameters into the WebSocket request builder.#[pyo3(get)]attribute to the new fields inWebSocketParamsto expose them to Python code, allowing users to get and set these options from Python.