Skip to content

feat(http): implement rich comparison for StatusCode with integers#490

Merged
0x676e67 merged 1 commit intomainfrom
feat
Jan 16, 2026
Merged

feat(http): implement rich comparison for StatusCode with integers#490
0x676e67 merged 1 commit intomainfrom
feat

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant quality-of-life improvement for the StatusCode class by enabling direct rich comparison with integer values. This change streamlines the process of checking HTTP status codes, making the code more intuitive and aligned with Pythonic practices. The accompanying example files have been updated to demonstrate this enhanced functionality, providing clearer and more concise usage patterns.

Highlights

  • Rich Comparison for StatusCode: Implemented Python's rich comparison protocol (__richcmp__) for the StatusCode class, allowing direct comparison of StatusCode objects with integers using standard comparison operators (e.g., status_code == 200).
  • Simplified Status Code Checks: Updated example scripts (http1_websocket.py and http2_websocket.py) to leverage the new rich comparison, removing the need for explicit .as_int() calls when comparing status codes.
  • Example Refinements: Removed outdated comments and updated the websocket connection URL in http1_websocket.py for better clarity and relevance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces rich comparison support for the StatusCode class, allowing direct comparison with integers. The implementation is a great start, but I've suggested an improvement to make it more robust and Pythonic by handling comparisons between StatusCode objects and returning NotImplemented for unsupported types. Additionally, I've noted that one of the updated examples uses a deprecated WebSocket service and provided a working alternative.

@0x676e67 0x676e67 merged commit 65af91e into main Jan 16, 2026
32 checks passed
@0x676e67 0x676e67 deleted the feat branch January 16, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant