feat(request): allow setting compressed and uncompressed cookies

[0x676e67]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Request and WebSocketRequest functionalities by allowing more flexible specification of cookies. Previously, cookies could only be provided as a dictionary. Now, users can also pass a single string, which will be parsed as a raw cookie header. This change is implemented by introducing a new Cookies type in the Rust core, which handles the conversion of both string and dictionary inputs into the appropriate internal representation, and updating the Python type hints to reflect this broader acceptance.

Highlights

• Flexible Cookie Input: The cookies parameter for requests now accepts both a single string (representing a raw cookie header) and a dictionary of key-value pairs, enhancing flexibility for users.
• New Cookies Type: A new Cookies struct has been introduced in the Rust backend to encapsulate the logic for parsing and handling different cookie input formats from Python.
• Refactored Cookie Extraction: The responsibility for extracting cookie HeaderValues from Python objects has been moved from the generic Extractor to the dedicated Cookies type, streamlining the codebase.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a feature to allow setting cookies from either a string or a dictionary, enhancing flexibility. The implementation involves a new Cookies struct in Rust to handle the conversion from Python types, and refactors the cookie extraction logic into the cookie.rs module for better organization. The changes are well-structured. I've provided a couple of suggestions to improve documentation clarity and optimize string handling for better performance. Overall, this is a good improvement.