Conversation
kreedzZhao
pushed a commit
to kreedzZhao/rnet
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the
rnetlibrary, including the addition of new enumerations for HTTP methods, versions, and impersonation options, as well as updates to the client and response handling code to use these new enums. The most important changes are detailed below:New Enumerations and Refactoring:
Added new enumerations for
Impersonate,ImpersonateOS,Method, andVersioninrnet.pyi, replacing the previous class definitions. This change simplifies the handling of these types and ensures consistency across the codebase. [1] [2] [3]Refactored the
src/typesmodule to use the new enums with conversion methods. This includes changes inimpersonate.rs,method.rs, andversion.rsto define enums with conversion and string representation methods. [1] [2] [3]Client and Response Updates:
Updated the
Clientimplementation insrc/client.rsto use the new enums forImpersonate,ImpersonateOS, andMethod. This includes changes to how these parameters are passed and converted in the request builder methods. [1] [2] [3]Modified the
ResponseandWebSocketimplementations insrc/responseto use the newVersionenum for handling HTTP versions. This ensures that the correct version is used and converted when processing responses. [1] [2]Additional Changes:
Added a new example script
examples/impersonate.pydemonstrating the use of theImpersonateclass with an asynchronous client request. This serves as a practical example of how to use the new impersonation features.Updated the
src/types/mod.rsto reflect the changes in the status code module, renaming it fromstatus_codetostatus. This aligns with the new enum-based approach. [1] [2]