Skip to content

chore(deps): update pyo3 to 0.28#506

Merged
0x676e67 merged 1 commit intomainfrom
build
Feb 11, 2026
Merged

chore(deps): update pyo3 to 0.28#506
0x676e67 merged 1 commit intomainfrom
build

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on upgrading the project's core Python-Rust binding dependencies, pyo3 and pyo3-async-runtimes, to their latest 0.28.0 versions. This update required adjusting the #[pyclass] attributes on several Rust structs to correctly handle Python object conversions, either by enabling from_py_object or explicitly skipping it where appropriate. A temporary patch for pyo3 from its Git repository has also been applied to facilitate this transition.

Highlights

  • Dependency Update: Updated the pyo3 and pyo3-async-runtimes crates to version 0.28.0 in Cargo.toml.
  • PyO3 Compatibility: Added the from_py_object attribute to numerous #[pyclass] definitions across various files to ensure compatibility with the updated pyo3 version's object conversion mechanisms. For Streamer and Response types, skip_from_py_object was added instead.
  • Temporary PyO3 Patch: Included a [patch.crates-io] entry in Cargo.toml to temporarily use a specific Git repository for pyo3.
Changelog
  • Cargo.toml
    • Updated pyo3 dependency from 0.27.0 to 0.28.0.
    • Updated pyo3-async-runtimes dependency from 0.27.0 to 0.28.0.
    • Added a [patch.crates-io] section to source pyo3 from its GitHub repository.
  • src/client.rs
    • Added from_py_object attribute to SocketAddr and Client #[pyclass] definitions.
  • src/client/body/stream.rs
    • Added skip_from_py_object attribute to the Streamer #[pyclass] definition.
  • src/client/resp/http.rs
    • Added skip_from_py_object attribute to the Response #[pyclass] definition.
  • src/client/resp/ws/msg.rs
    • Added from_py_object attribute to the Message #[pyclass] definition.
  • src/cookie.rs
    • Added from_py_object attribute to Cookie and Jar #[pyclass] definitions.
  • src/dns.rs
    • Added from_py_object attribute to the ResolverOptions #[pyclass] definition.
  • src/emulation.rs
    • Added from_py_object attribute to the EmulationOption #[pyclass] definition.
  • src/http.rs
    • Added from_py_object attribute to the StatusCode #[pyclass] definition.
  • src/http1.rs
    • Added from_py_object attribute to the Http1Options #[pyclass] definition.
  • src/http2.rs
    • Added from_py_object attribute to StreamId, StreamDependency, Priority, Priorities, PseudoOrder, SettingsOrder, and Http2Options #[pyclass] definitions.
  • src/macros.rs
    • Added from_py_object attribute to #[pyclass] definitions within the define_enum! macros.
  • src/proxy.rs
    • Added from_py_object attribute to the Proxy #[pyclass] definition.
  • src/redirect.rs
    • Added from_py_object attribute to Policy and Action #[pyclass] definitions.
  • src/tls.rs
    • Added from_py_object attribute to the TlsOptions #[pyclass] definition.
  • src/tls/identity.rs
    • Added from_py_object attribute to the Identity #[pyclass] definition.
  • src/tls/keylog.rs
    • Added from_py_object attribute to the KeyLog #[pyclass] definition.
  • src/tls/store.rs
    • Added from_py_object attribute to the CertStore #[pyclass] definition.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates pyo3 and pyo3-async-runtimes to version 0.28.0. The changes across the Rust source files correctly adapt to the pyo3 v0.28 API, which now requires explicit from_py_object or skip_from_py_object attributes on pyclass structs. My main concern is with the addition of a [patch.crates-io] section in Cargo.toml that points pyo3 to its git repository without a specific revision. This poses a risk to build reproducibility and should be addressed.

@0x676e67 0x676e67 merged commit 7647f8f into main Feb 11, 2026
34 checks passed
@0x676e67 0x676e67 deleted the build branch February 11, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant